Source/core/dom/DocumentMarkerController.cpp - Issue 796913002: Use C++11 range-based loop for core/clipboard, core/dom and core/testing

Unified Diff: Source/core/dom/DocumentMarkerController.cpp

Issue 796913002: Use C++11 range-based loop for core/clipboard, core/dom and core/testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: make auto clear Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DocumentMarkerController.cpp

diff --git a/Source/core/dom/DocumentMarkerController.cpp b/Source/core/dom/DocumentMarkerController.cpp

index 8211471e19280fa2f2830a44b8635520c9a8bfb0..fe91f4f6196eaf38710c9f3bdcee562c2c2966ba 100644

--- a/Source/core/dom/DocumentMarkerController.cpp

+++ b/Source/core/dom/DocumentMarkerController.cpp

@@ -444,10 +444,7 @@ DocumentMarkerVector DocumentMarkerController::markersInRange(Range* range, Docu

Node* pastLastNode = range->pastLastNode();

for (Node* node = range->firstNode(); node != pastLastNode; node = NodeTraversal::next(*node)) {

- DocumentMarkerVector markers = markersFor(node);

- DocumentMarkerVector::const_iterator end = markers.end();

- for (DocumentMarkerVector::const_iterator it = markers.begin(); it != end; ++it) {

- DocumentMarker* marker = *it;

+ for (DocumentMarker* marker : markersFor(node)) {

Julien - ping for review 2015/01/02 09:42:02 const DocumentMarker* (it was a const iterator).

zhaoze.zhou 2015/01/05 15:17:57 it's strange that this one can not mark as const.

dcheng 2015/01/05 22:01:09 This makes sense--DocumentMarkerVectors is a conta

if (!markerTypes.contains(marker->type()))

continue;

if (node == startContainer && marker->endOffset() <= static_cast<unsigned>(range->startOffset()))

@@ -721,10 +718,7 @@ bool DocumentMarkerController::hasMarkers(Range* range, DocumentMarker::MarkerTy