build/module_args/v8.gni - Issue 796903002: [GN] Set v8_use_external_snapshot_data for the same configurations as GN.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/module_args/v8.gni

Issue 796903002: [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix location of natives_blob.bin and snapshot_blob.bin after their output was moved in V8 Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 if (is_android) {	5 if (is_android) {

6 import("//build/config/android/config.gni")	6 import("//build/config/android/config.gni")

7 }	7 }

8	8

9 # TODO(baixo) enable this once this lands:	9 v8_use_external_startup_data =

10 # https://codereview.chromium.org/749213004	10 !((is_android && is_android_webview_build) \|\| is_chromeos \|\| is_win)

11 # v8_use_external_startup_data = is_android && !is_android_webview_build

12 v8_use_external_startup_data = false

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/BUILD.gn » ('j') | no next file with comments »