Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 796883002: buildbot package: actually find commits for each build during ingestion (Closed)

Created:
6 years ago by borenet
Modified:
6 years ago
Reviewers:
jcgregorio, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Visibility:
Public.

Description

buildbot package: actually find commits for each build during ingestion BUG=skia:3125 Committed: https://skia.googlesource.com/buildbot/+/9e8711c4abe03ddc64584aa57e38ed87a00cbe5b

Patch Set 1 #

Total comments: 3

Patch Set 2 : Pretty format the JSON #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6618 lines, -52 lines) Patch
M go/buildbot/buildbot_test.go View 19 chunks +180 lines, -25 lines 0 comments Download
M go/buildbot/db.go View 3 chunks +35 lines, -7 lines 0 comments Download
M go/buildbot/ingest.go View 6 chunks +59 lines, -10 lines 0 comments Download
M go/buildbot/testdata/builders_android.json View 1 1 chunk +432 lines, -1 line 0 comments Download
M go/buildbot/testdata/builders_fyi.json View 1 1 chunk +289 lines, -1 line 0 comments Download
M go/buildbot/testdata/default_build.json View 1 1 chunk +1651 lines, -1 line 0 comments Download
M go/buildbot/testdata/housekeeper1035.json View 1 1 chunk +969 lines, -1 line 0 comments Download
A go/buildbot/testdata/testrepo.zip View Binary file 0 comments Download
M go/buildbot/testdata/unfinished_build.json View 1 1 chunk +933 lines, -1 line 0 comments Download
M go/buildbot/testdata/venue464.json View 1 1 chunk +635 lines, -1 line 0 comments Download
M go/buildbot/testdata/venue465.json View 1 1 chunk +611 lines, -1 line 0 comments Download
M go/buildbot/testdata/venue466.json View 1 1 chunk +814 lines, -1 line 0 comments Download
M monitoring/go/datahopper/main.go View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
borenet
https://codereview.chromium.org/796883002/diff/1/go/buildbot/buildbot_test.go File go/buildbot/buildbot_test.go (right): https://codereview.chromium.org/796883002/diff/1/go/buildbot/buildbot_test.go#newcode110 go/buildbot/buildbot_test.go:110: clearDB(t, ProdDatabaseConfig(true)) Now that ingesting a build runs findCommitsForBuild ...
6 years ago (2014-12-11 16:34:24 UTC) #2
jcgregorio
https://codereview.chromium.org/796883002/diff/1/go/buildbot/testdata/default_build.json File go/buildbot/testdata/default_build.json (right): https://codereview.chromium.org/796883002/diff/1/go/buildbot/testdata/default_build.json#newcode1 go/buildbot/testdata/default_build.json:1: {"blame":["kkinnunen@nvidia.com"],"builderName":"Test-Ubuntu12-ShuttleA-GTX660-x86-Release","currentStep":null,"eta":null,"logs":[["preamble","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/steps/logs/preamble"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/steps/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/update_scripts/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/setup_build/logs/stdio"],["run_recipe","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/setup_build/logs/run_recipe"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/gclient%20setup/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/gclient%20sync/logs/stdio"],["json.output","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/gclient%20sync/logs/json.output"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/get%20CHROME_PATH/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/get%20CHROME_PATH/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/build%20most/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fgm%2Factual/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fgm%2Factual/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fgm%2Factual/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fgm%2Factual/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Factual%2FBUILDER/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Factual%2FBUILDER/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Factual%2FBUILDER/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Factual%2FBUILDER/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/gm/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/Compare%20GMs/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/Upload%20GM%20Results/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fbuild%2Fdm/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fbuild%2Fdm/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fbuild%2Fdm/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fbuild%2Fdm/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/dm/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/Upload%20DM%20Results/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/read%20...%2Fskia%2FSKP_VERSION/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/read%20...%2Fskps%2FSKP_VERSION/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/render_pdfs/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fbuild%2Fskimage_in/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fbuild%2Fskimage_in/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fbuild%2Fskimage_in/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fbuild%2Fskimage_in/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/gsutil%20download%20skimage%20files/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fbuild%2Fskimage_out/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fbuild%2Fskimage_out/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fbuild%2Fskimage_out/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fbuild%2Fskimage_out/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fskimage_out%2Fimages/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fskimage_out%2Fimages/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fskimage_out%2Fimages/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fskimage_out%2Fimages/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fskimage_out%2FBUILDER/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/rmtree%20...%2Fskimage_out%2FBUILDER/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fskimage_out%2FBUILDER/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/makedirs%20...%2Fskimage_out%2FBUILDER/logs/python.inline"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/skimage/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/gsutil%20upload%20skimage%20actual%20images/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/gsutil%20upload%20skimage%20actual%20summary/logs/stdio"],["stdio","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/assert%20skimage%20expectations/logs/stdio"],["python.inline","http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/721/steps/assert%20skimage%20expectations/logs/python.inline"]],"number":721,"properties":[["blamelist",["kkinnunen@nvidia.com"],"Build"],["branch","master","Build"],["buildbotURL","http://build.chromium.org/p/client.skia/","master.cfg"],["buildername","Test-Ubuntu12-ShuttleA-GTX660-x86-Release","Builder"],["buildnumber",721,"Build"],["git_revision","051955c355eb742550ddde4eccc3e90b6dc5b887","Change"],["got_revision","051955c355eb742550ddde4eccc3e90b6dc5b887","Annotation(gclient sync)"],["mastername","client.skia","master.cfg"],["project","skia","Build"],["repository","https://skia.googlesource.com/skia.git","Build"],["revision","051955c355eb742550ddde4eccc3e90b6dc5b887","Build"],["scheduler","skia_percommit","Scheduler"],["slavename","skiabot-shuttle-ubuntu12-gtx660-000","BuildSlave"],["workdir","/home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-gtx660-000/build/slave/Test-Ubuntu12-ShuttleA-GTX660-x86-Release","slave"]],"reason":"scheduler","results":0,"slave":"skiabot-shuttle-ubuntu12-gtx660-000","sourceStamp":{"branch":"master","changes":[{"at":"Wed 03 Dec 2014 06:18:12","branch":"master","category":null,"comments":"Make debugger not fail ...
6 years ago (2014-12-12 12:18:39 UTC) #3
borenet
Done.
6 years ago (2014-12-12 13:54:29 UTC) #4
jcgregorio
lgtm
6 years ago (2014-12-12 14:07:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796883002/20001
6 years ago (2014-12-12 14:16:58 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 14:17:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/9e8711c4abe03ddc64584aa57e38ed87a00c...

Powered by Google App Engine
This is Rietveld 408576698