Oilpan: fix build after r186944.

Source/core/inspector/AsyncCallStackTracker.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 42 matching lines @@
 static const char requestAnimationFrameName[] = "requestAnimationFrame";
 static const char xhrSendName[] = "XMLHttpRequest.send";
 static const char enqueueMutationRecordName[] = "Mutation";
 
 }
 
 namespace blink {
 
 template <class K>
 class AsyncCallStackTracker::AsyncCallChainMap final {
+    ALLOW_ONLY_INLINE_ALLOCATION();
 public:
-    typedef HashMap<K, RefPtr<AsyncCallStackTracker::AsyncCallChain> > MapType;
+    using MapType = WillBeHeapHashMap<K, RefPtrWillBeMember<AsyncCallStackTracker::AsyncCallChain>>;
     explicit AsyncCallChainMap(AsyncCallStackTracker* tracker) : m_tracker(tracker) { }
 
     ~AsyncCallChainMap()
     {
         clear();
     }
 
     void clear()
     {
         for (auto it : m_asyncCallChains) {

[haraken, 2014/12/11 16:22:14]

Is it OK to touch m_asyncCallChains in AsyncCallChainMap's destructor?

[sof, 2014/12/11 16:27:38]

Certainly isn't, thanks for catching. What a mess, will fix it when I get a
chance.

[aandrey, 2014/12/11 20:43:29]

Could you please elaborate why it is not OK? Is it Oilpan specific?

             if (AsyncCallStackTracker::Listener* listener = m_tracker->m_listener)
                 listener->didRemoveAsyncCallChain(it.value.get());
             else
                 break;
         }
         m_asyncCallChains.clear();
     }
 
     void set(typename MapType::KeyPeekInType key, PassRefPtrWillBeRawPtr<AsyncCallChain> chain)
     {
         m_asyncCallChains.set(key, chain);
     }
 
     bool contains(typename MapType::KeyPeekInType key) const
     {
         return m_asyncCallChains.contains(key);
     }
 
     PassRefPtrWillBeRawPtr<AsyncCallChain> get(typename MapType::KeyPeekInType key) const
     {
         return m_asyncCallChains.get(key);
     }
 
     void remove(typename MapType::KeyPeekInType key)
     {
-        RefPtr<AsyncCallStackTracker::AsyncCallChain> chain = m_asyncCallChains.take(key);
+        RefPtrWillBeRawPtr<AsyncCallStackTracker::AsyncCallChain> chain = m_asyncCallChains.take(key);
         if (chain && m_tracker->m_listener)
             m_tracker->m_listener->didRemoveAsyncCallChain(chain.get());
     }
 
+    void trace(Visitor* visitor)
+    {
+        visitor->trace(m_asyncCallChains);
+    }
+
 private:
     AsyncCallStackTracker* m_tracker;
     MapType m_asyncCallChains;
 };
 
 class AsyncCallStackTracker::ExecutionContextData final : public NoBaseWillBeGarbageCollectedFinalized<ExecutionContextData>, public ContextLifecycleObserver {
     WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
 public:
     ExecutionContextData(AsyncCallStackTracker* tracker, ExecutionContext* executionContext)
         : ContextLifecycleObserver(executionContext)
@@ skipping 482 matching lines @@
 
 void AsyncCallStackTracker::trace(Visitor* visitor)
 {
     visitor->trace(m_currentAsyncCallChain);
 #if ENABLE(OILPAN)
     visitor->trace(m_executionContextDataMap);
 #endif
 }
 
 } // namespace blink