Issue 796853003: Move remaining test targets out of //mojo/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 796853003: Move remaining test targets out of //mojo/public. (Closed)

Created:
6 years ago by qsr

Modified:
6 years ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, blundell

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move remaining test targets out of //mojo/public. The test targets currently in //mojo/public depend on the EDK to run and thus are not part of the public SDK. This CL converts the remaining test targets in the public SDK into testonly mojo_sdk_source_sets, and adds new test targets under the EDK that depend on the corresponding source_sets as well as the EDK mechanism for running the unittests. Note that the dependencies from the test targets to the source_sets are specified via relative paths as part of the work toward having the EDK be flexible wrt its location in a client repo. Initial review: https://codereview.chromium.org/767083006/ BUG=439082 TBR=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0bcf40dec38480296394ffb28e62dac9a6854e3d

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -27 lines)			Patch
M	mojo/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/test/BUILD.gn	View	8 chunks	+14 lines, -8 lines	0 comments	Download
M	mojo/public/cpp/system/tests/BUILD.gn	View	1 chunk	+14 lines, -9 lines	0 comments	Download
M	mojo/public/cpp/utility/tests/BUILD.gn	View	1 chunk	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

Committed patchset #1 (id:1) manually as 0bcf40dec38480296394ffb28e62dac9a6854e3d (presubmit successful).

6 years ago (2014-12-15 09:13:30 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages