Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 79683005: Merge 235499 "Fix a small bug in bookmarks_bridge.cc" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1700/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc
===================================================================
--- chrome/browser/android/bookmarks/bookmarks_bridge.cc (revision 236531)
+++ chrome/browser/android/bookmarks/bookmarks_bridge.cc (working copy)
@@ -87,6 +87,12 @@
long folder_id = Java_BookmarkId_getId(env, j_folder_id_obj);
int type = Java_BookmarkId_getType(env, j_folder_id_obj);
const BookmarkNode* folder = GetFolderWithFallback(folder_id, type);
+ // Recreate the java bookmarkId object due to fallback.
+ ScopedJavaLocalRef<jobject> folder_id_obj =
+ Java_BookmarksBridge_createBookmarkId(
+ env, folder->id(), GetBookmarkType(folder));
+ j_folder_id_obj = folder_id_obj.obj();
+
// If this is the Mobile bookmarks folder then add the "Managed bookmarks"
// folder first, so that it's the first entry.
if (folder == bookmark_model_->mobile_node() &&
@@ -114,6 +120,12 @@
long folder_id = Java_BookmarkId_getId(env, j_folder_id_obj);
int type = Java_BookmarkId_getType(env, j_folder_id_obj);
const BookmarkNode* folder = GetFolderWithFallback(folder_id, type);
+ // Recreate the java bookmarkId object due to fallback.
+ ScopedJavaLocalRef<jobject> folder_id_obj =
+ Java_BookmarksBridge_createBookmarkId(
+ env, folder->id(), GetBookmarkType(folder));
+ j_folder_id_obj = folder_id_obj.obj();
+
// Get the folder heirarchy
const BookmarkNode* node = folder;
while (node) {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698