Disable generating of code cache if the debugger is loaded

Disable generating of code cache if the debugger is loaded

BUG=440880
R=yangguo@chromium.org,dcarney@chromium.org,vogelheim@chromium.org
LOG=n

[dcarney, 2014-12-11 10:56:26]

lgtm

[Yang, 2014-12-11 10:57:07]

On 2014/12/11 10:54:49, jochen (slow) wrote:

lgtm.

[vogelheim, 2014-12-11 11:05:28]

If the serializations are broken, then we'd also need to update the V8 version
number to make the old, broken serializations disappear.

[vogelheim, 2014-12-11 11:06:22]

lgtm

Looks good, but I'd like to suggest an alternative.

https://codereview.chromium.org/796823002/diff/1/src/compiler.cc
File src/compiler.cc (left):

https://codereview.chromium.org/796823002/diff/1/src/compiler.cc#oldcode1287
src/compiler.cc:1287: if (FLAG_serialize_toplevel &&
I'd prefer to check the condition once upfront and to pass in kNoCompileOptions
when isolate->debug()->is_loaded().

Good places to do that might be either the top of Compile::CompileScript, where
we're sanity checking the compile options, or maybe at the top of
ScriptCompiler::CompileUnbound in api.cc, where we modify the options in similar
fashion (but for other reasons).

[vogelheim, 2014-12-11 11:09:42]

On 2014/12/11 11:05:28, vogelheim wrote:
> If the serializations are broken, then we'd also need to update the V8 version
> number to make the old, broken serializations disappear.

Ah wait, it crashes in the serializer, so this point is moot. :)

[jochen (gone - plz use gerrit), 2014-12-11 12:11:45]

ptal

[vogelheim1, 2014-12-11 12:24:40]

vogelheim@google.com changed reviewers:
+ vogelheim@google.com

[vogelheim1, 2014-12-11 12:24:41]

lgtm

[jochen (gone - plz use gerrit), 2014-12-11 12:31:24]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-12-11 12:31:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796823002/20001

[commit-bot: I haz the power, 2014-12-11 12:58:41]

Committed patchset #2 (id:20001)