Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: tools/perf/page_sets/typical_25.py

Issue 796813003: [Telemetry] Remove empty action_name_to_run for Startup, SessionRestore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/startup.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/typical_25.py
diff --git a/tools/perf/page_sets/typical_25.py b/tools/perf/page_sets/typical_25.py
index 89395a39a3bcfaa9e349705d1a95b486784f9b31..57983bb55c3b79e437af7f025dce5a8fe666afd1 100644
--- a/tools/perf/page_sets/typical_25.py
+++ b/tools/perf/page_sets/typical_25.py
@@ -7,12 +7,15 @@ from telemetry.page import page_set as page_set_module
class Typical25Page(page_module.Page):
- def __init__(self, url, page_set):
+ def __init__(self, url, page_set, run_no_page_interactions):
super(Typical25Page, self).__init__(url=url, page_set=page_set)
self.user_agent_type = 'desktop'
self.archive_data_file = 'data/typical_25.json'
+ self._run_no_page_interactions = run_no_page_interactions
def RunPageInteractions(self, action_runner):
+ if self._run_no_page_interactions:
+ return
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollPage()
@@ -23,7 +26,7 @@ class Typical25PageSet(page_set_module.PageSet):
""" Pages designed to represent the median, not highly optimized web """
- def __init__(self):
+ def __init__(self, make_pages_with_no_interactions=False):
super(Typical25PageSet, self).__init__(
user_agent_type='desktop',
archive_data_file='data/typical_25.json',
@@ -71,4 +74,5 @@ class Typical25PageSet(page_set_module.PageSet):
]
for url in urls_list:
- self.AddUserStory(Typical25Page(url, self))
+ self.AddUserStory(
+ Typical25Page(url, self, make_pages_with_no_interactions))
« no previous file with comments | « tools/perf/measurements/startup.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698