Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 796803002: ozone: mouse button swap shouldn't affect touchpad physical click (Closed)

Created:
6 years ago by Shecky Lin
Modified:
6 years ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: mouse button swap shouldn't affect touchpad physical click The CL fixes the problem where the touchpad physical clicks become right clicks when the mouse primary button is swapped. Contributed by sheckylin@chromium.org BUG=440932 TEST=link_freon ChromeOS build Committed: https://crrev.com/4cc22233c4c72092abaae59d89a8a26a1329ecc0 Cr-Commit-Position: refs/heads/master@{#308143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alexst (slow to review)
lgtm
6 years ago (2014-12-11 14:03:49 UTC) #2
Shecky Lin
Seems like I forget to add reviewers yesterday. Sorry about that. spang@, could you take ...
6 years ago (2014-12-12 07:01:21 UTC) #4
spang
lgtm
6 years ago (2014-12-12 18:45:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796803002/1
6 years ago (2014-12-12 18:46:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 19:30:43 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 19:31:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cc22233c4c72092abaae59d89a8a26a1329ecc0
Cr-Commit-Position: refs/heads/master@{#308143}

Powered by Google App Engine
This is Rietveld 408576698