Make app list recommendations into their own DisplayType.

Make app list recommendations into their own DisplayType.

This CL makes the app list recommendations their own
SearchResult::DisplayType. This prevents recommendations from flashing up
for an instant when the search query is deleted.

BUG=440051
Committed: https://crrev.com/c2a0964bf58348edcbd4cbb074336e807ba22a51
Cr-Commit-Position: refs/heads/master@{#308316}

[calamity, 2014-12-11 07:35:48]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-12-11 08:00:57]

Hmm. I'm pensive about whether this is the correct way to resolve it.

Isn't it the case that if I do a search: "a" then press backspace, after this
CL, my results will completely disappear, because it will make a query for ""
but there will be no LIST or TILE results, so I will see nothing? So that means
the search results will instantly disappear, instead of sliding up?

I think ideally we would solve this by *not* making any changes, and continuing
to show the results for "a" while it slides up, then changing to a
recommendations query.

We can discuss tomorrow.

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.cc
File ui/app_list/search_result.cc (right):

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.cc...
ui/app_list/search_result.cc:75: case DISPLAY_RECOMMENDATION:
// Fallthrough.

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.h
File ui/app_list/search_result.h (right):

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.h#...
ui/app_list/search_result.h:35: DISPLAY_RECOMMENDATION,
// RECOMMENDATION is essentially the same as TILE, but has a separate type, to
avoid recommendations flashing up on search results, and vice versa.

[calamity, 2014-12-12 05:00:24]

As discussed, this changes the behavior to the same as the classic launcher and
is an improvement, so we're going with it.

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.cc
File ui/app_list/search_result.cc (right):

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.cc...
ui/app_list/search_result.cc:75: case DISPLAY_RECOMMENDATION:
On 2014/12/11 08:00:57, Matt Giuca wrote:
> // Fallthrough.

Done.

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.h
File ui/app_list/search_result.h (right):

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.h#...
ui/app_list/search_result.h:35: DISPLAY_RECOMMENDATION,
On 2014/12/11 08:00:57, Matt Giuca wrote:
> // RECOMMENDATION is essentially the same as TILE, but has a separate type, to
> avoid recommendations flashing up on search results, and vice versa.

Is this necessary? I don't have a comment there saying that TILE is essentially
the same as LIST except it has a different size and prevents TILE results from
showing in the LIST results and vice versa.

[Matt Giuca, 2014-12-12 05:13:58]

lgtm

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.h
File ui/app_list/search_result.h (right):

https://codereview.chromium.org/796793002/diff/1/ui/app_list/search_result.h#...
ui/app_list/search_result.h:35: DISPLAY_RECOMMENDATION,
OK fair enough.

[calamity, 2014-12-12 05:23:54]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-12 05:24:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796793002/1

[commit-bot: I haz the power, 2014-12-12 05:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 05:28:03]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[calamity, 2014-12-15 00:54:36]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-15 00:55:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796793002/1

[commit-bot: I haz the power, 2014-12-15 01:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-15 01:48:20]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2014-12-15 03:21:25]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-15 03:22:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796793002/20001

[commit-bot: I haz the power, 2014-12-15 05:26:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-15 05:27:01]

Patchset 2 (id:??) landed as
https://crrev.com/c2a0964bf58348edcbd4cbb074336e807ba22a51
Cr-Commit-Position: refs/heads/master@{#308316}