Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 796783003: Work around CG assert drawing tiny glyphs. (Closed)

Created:
3 years, 11 months ago by bungeman-skia
Modified:
3 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m40
Target Ref:
refs/heads/chrome/m40
Project:
skia
Visibility:
Public.

Description

Work around CG assert drawing tiny glyphs. For some fonts when drawing glyphs at CGFLOAT_MIN size, CG will assert internally. Instead, request such glyphs at size 1, and scale them down to 0 with a transform. This change follows the pattern set by 3490263287e9432119c501884e45840de4d986bc "Replace use of deprecated CG methods." on master. BUG=chromium:441538 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/f4153260844a88d208c30bac5cc6902e716289c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/ports/SkFontHost_mac.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bungeman-skia
This is a change directly to the m40 branch. The master code has changed to ...
3 years, 11 months ago (2014-12-12 19:54:32 UTC) #2
reed1
lgtm
3 years, 11 months ago (2014-12-12 19:56:19 UTC) #3
bungeman-skia
3 years, 11 months ago (2014-12-12 19:59:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4153260844a88d208c30bac5cc6902e716289c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698