Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 796783002: Restructure public side of navigation service. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of navigation service. This CL goes from this: //mojo/services/public/interfaces/navigation to this: //mojo/services/navigation/public/interfaces This CL also makes the Mojo-side changes necessary to roll this change into Chromium. TBR=beng Committed: https://chromium.googlesource.com/external/mojo/+/1caebd6f70aa9b05a96e87ee035556e11b14c700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -65 lines) Patch
M examples/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/embedded_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/embedded_app/embedded_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/keyboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/keyboard/keyboard.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/media_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/media_viewer/media_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/nesting_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/debug_panel.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/navigation/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/navigation/public/interfaces/navigation.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/public/interfaces/navigation/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/public/interfaces/navigation/navigation.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/debugger.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/navigator_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
blundell
6 years ago (2014-12-11 07:49:07 UTC) #1
blundell
6 years ago (2014-12-11 07:49:22 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1caebd6f70aa9b05a96e87ee035556e11b14c700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698