Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: sky/engine/core/dom/Element.cpp

Issue 796713002: Turn StyleSharing to 11. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/Element.cpp
diff --git a/sky/engine/core/dom/Element.cpp b/sky/engine/core/dom/Element.cpp
index dd35d8b8b15a9507f24b72ec1cac5e528b429b82..171c4d084b9439d3154cc21322541323f15e4403 100644
--- a/sky/engine/core/dom/Element.cpp
+++ b/sky/engine/core/dom/Element.cpp
@@ -990,15 +990,8 @@ StyleRecalcChange Element::recalcOwnStyle(StyleRecalcChange change)
ASSERT(oldStyle);
if (RenderObject* renderer = this->renderer()) {
- if (localChange != NoChange) {
+ if (localChange != NoChange)
renderer->setStyle(newStyle.get());
- } else {
- // Although no change occurred, we use the new style so that the cousin style sharing code won't get
- // fooled into believing this style is the same.
- // FIXME: We may be able to remove this hack, see discussion in
- // https://codereview.chromium.org/30453002/
- renderer->setStyleInternal(newStyle.get());
- }
}
if (styleChangeType() >= SubtreeStyleChange)

Powered by Google App Engine
This is Rietveld 408576698