Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 796693003: Use Surfaces on Windows, Linux, and Mac OS (second try) (Closed)

Created:
6 years ago by jbauman
Modified:
6 years ago
Reviewers:
piman
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Surfaces on Windows, Linux, and Mac OS (second try) Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet. BUG=334090 TBR=piman@chromium.org Committed: https://crrev.com/8a61bd41b8a04bde04d7b538e3d9a42acd7c4ec7 Cr-Commit-Position: refs/heads/master@{#308028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbauman
Let's try this again.
6 years ago (2014-12-11 23:10:36 UTC) #3
jbauman
6 years ago (2014-12-12 00:15:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796693003/1
6 years ago (2014-12-12 00:36:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 02:19:56 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8a61bd41b8a04bde04d7b538e3d9a42acd7c4ec7 Cr-Commit-Position: refs/heads/master@{#308028}
6 years ago (2014-12-12 02:20:43 UTC) #8
lushnikov
6 years ago (2014-12-12 14:23:43 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/802683002/ by lushnikov@chromium.org.

The reason for reverting is: Speculative revert:
virtual/slimmingpaint/fast/text/fallback-traits-fixup.html is crashing on Mac.

Example build: http://goo.gl/Ol8CHS

Flakiness dashboard: http://goo.gl/KGLmLS.

Powered by Google App Engine
This is Rietveld 408576698