Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 796643006: win: avoid warning on return of base::RandGenerator (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: avoid warning on return of base::RandGenerator Else, d:\src\crashpad\crashpad\util\net\http_multipart_builder.cc(50) : warning C4244: 'initializing' : conversion from 'uint64_t' to 'int', possible loss of data R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3eeae10ebeb96794682a52e52199a5d645a067d5

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M util/net/http_multipart_builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years ago (2014-12-17 01:07:53 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/796643006/diff/1/util/net/http_multipart_builder.cc File util/net/http_multipart_builder.cc (right): https://codereview.chromium.org/796643006/diff/1/util/net/http_multipart_builder.cc#newcode50 util/net/http_multipart_builder.cc:50: static_cast<int>(base::RandGenerator(strlen(kCharacters))); or base::RandInt(0, strlen(kCharacters) - 1)
6 years ago (2014-12-17 01:15:25 UTC) #2
Mark Mentovai
(your choice)
6 years ago (2014-12-17 01:15:32 UTC) #3
scottmg
https://codereview.chromium.org/796643006/diff/1/util/net/http_multipart_builder.cc File util/net/http_multipart_builder.cc (right): https://codereview.chromium.org/796643006/diff/1/util/net/http_multipart_builder.cc#newcode50 util/net/http_multipart_builder.cc:50: static_cast<int>(base::RandGenerator(strlen(kCharacters))); On 2014/12/17 01:15:24, Mark Mentovai wrote: > or ...
6 years ago (2014-12-17 18:49:46 UTC) #4
scottmg
6 years ago (2014-12-17 18:50:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3eeae10ebeb96794682a52e52199a5d645a067d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698