Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 796643002: Added support for aria-invalid and for reporting the invalid state of form controls. (Closed)

Created:
6 years ago by nektarios
Modified:
6 years ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added support for aria-invalid and for reporting the invalid state of form controls. BUG=384834 R=dmazzoni Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187500

Patch Set 1 #

Total comments: 3

Patch Set 2 : Switched to a fixed set of aria-invalid values instead of passing unknown values to the browser. #

Total comments: 1

Patch Set 3 : Added ariaInvalidValue function to return the actual value of aria-invalid when it is set to an unkā€¦ #

Patch Set 4 : Properly exported newly added functions, invalidState() and ariaInvalidValue(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M Source/modules/accessibility/AXNodeObject.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M public/web/WebAXObject.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
nektarios
6 years ago (2014-12-10 23:57:49 UTC) #1
dmazzoni
I'm okay with returning strings for ARIA-only attributes that just get exposed directly to AT. ...
6 years ago (2014-12-11 23:43:11 UTC) #2
blink-reviews
OK but the ARIA standard says that if the value is unknown we should return ...
6 years ago (2014-12-12 00:53:16 UTC) #3
blink-reviews
> > I was wrong. I was looking at an earlier version of the spec. ...
6 years ago (2014-12-12 01:11:55 UTC) #4
dmazzoni
lgtm +mkwst for owners review of the public api https://codereview.chromium.org/796643002/diff/20001/Source/modules/accessibility/AXNodeObject.cpp File Source/modules/accessibility/AXNodeObject.cpp (right): https://codereview.chromium.org/796643002/diff/20001/Source/modules/accessibility/AXNodeObject.cpp#newcode1041 Source/modules/accessibility/AXNodeObject.cpp:1041: ...
6 years ago (2014-12-17 00:59:44 UTC) #6
blink-reviews
Done. Also added ariaInvalidValue which will be set to the actual value when WebAXInvalidState == ...
6 years ago (2014-12-17 02:21:29 UTC) #7
Mike West
public/ LGTM.
6 years ago (2014-12-17 08:44:01 UTC) #8
dmazzoni
Nevermind about fastGetAttribute - as you discovered, AXObject::getAttribute already calls fastGetAttribute. Please do add the ...
6 years ago (2014-12-17 17:28:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796643002/60001
6 years ago (2014-12-18 22:51:19 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-19 00:40:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187500

Powered by Google App Engine
This is Rietveld 408576698