Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 796633002: Move some DocumentTabModel files upstream (Closed)

Created:
6 years ago by gone
Modified:
6 years ago
Reviewers:
Ted C, cjhopman, Maria
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some DocumentTabModel files upstream * Moves the DocumentTabModel interface upstream. * Moves the DocumentTabModelInfo protobuf that stores basic info about a DocumentTabModel upstream. Formerly called DocumentDatabase. * Temporarily adds findbugs warnings until the DocumentTabModelImpl moves upstream. BUG=415747 NOTRY=true Committed: https://crrev.com/0dd63b3debbea98295f3b5aa29499257adc7a9bf Cr-Commit-Position: refs/heads/master@{#307952}

Patch Set 1 #

Patch Set 2 : Temporary findbugs workaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -0 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java View 1 chunk +182 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/document_tab_model_info.proto View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
gone
6 years ago (2014-12-10 23:49:04 UTC) #2
gone
+Maria for file move +Chris for GN check
6 years ago (2014-12-10 23:49:35 UTC) #4
cjhopman
gn lgtm
6 years ago (2014-12-10 23:51:07 UTC) #5
Maria
lgtm
6 years ago (2014-12-10 23:57:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796633002/1
6 years ago (2014-12-11 00:05:30 UTC) #8
gone
6 years ago (2014-12-11 00:32:40 UTC) #10
Ted C
On 2014/12/11 00:32:40, dfalcantara wrote: owners - lgtm
6 years ago (2014-12-11 00:32:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796633002/1
6 years ago (2014-12-11 00:35:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/29785)
6 years ago (2014-12-11 01:36:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796633002/20001
6 years ago (2014-12-11 18:35:44 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29775)
6 years ago (2014-12-11 18:49:25 UTC) #20
gone
Submitting NOTRY=true to get around temporary findbugs additions.
6 years ago (2014-12-11 19:41:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796633002/20001
6 years ago (2014-12-11 19:42:21 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 19:43:35 UTC) #24
commit-bot: I haz the power
6 years ago (2014-12-11 19:44:26 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dd63b3debbea98295f3b5aa29499257adc7a9bf
Cr-Commit-Position: refs/heads/master@{#307952}

Powered by Google App Engine
This is Rietveld 408576698