Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 796623005: Increase the cache size of fontconfig queries. (Closed)

Created:
5 years, 11 months ago by Jun Mukai
Modified:
5 years, 11 months ago
CC:
chromium-reviews, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase the cache size of fontconfig queries. As is described in http://crbug.com/440551#c28, the cache size 64 isn't big enough in ChromeOS, usually ChromeOS has fonts as much as 100. Unsupported glyph can run out this cache with a single character. BUG=440551 R=derat@chromium.org, ckocagil@chromium.org TBR=asvitkine@chromium.org TEST=open data:text/html;charset=UTF8,<title>a%E2%9C%A8</title> and see the slowness around drawing has gone. Committed: https://crrev.com/b18055e3d9b5b026c5c26b1650d38ef1eb4c97e6 Cr-Commit-Position: refs/heads/master@{#311568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/font_render_params_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Jun Mukai
5 years, 11 months ago (2015-01-14 21:57:41 UTC) #2
ckocagil
lgtm
5 years, 11 months ago (2015-01-14 22:06:25 UTC) #3
Jun Mukai
Thanks. TBR-ing...
5 years, 11 months ago (2015-01-14 22:12:19 UTC) #5
Alexei Svitkine (slow)
lgtm
5 years, 11 months ago (2015-01-14 22:13:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796623005/1
5 years, 11 months ago (2015-01-14 22:13:38 UTC) #8
Daniel Erat
lgtm wow, this has grown a lot. it was just intended as a minor optimization ...
5 years, 11 months ago (2015-01-14 23:08:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 23:09:12 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 23:09:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b18055e3d9b5b026c5c26b1650d38ef1eb4c97e6
Cr-Commit-Position: refs/heads/master@{#311568}

Powered by Google App Engine
This is Rietveld 408576698