Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 796623003: Support multiple interrupt requests in v8 API. (Closed)

Created:
6 years ago by alph
Modified:
6 years ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support multiple interrupt requests in v8 API. There might be a number of clients that would like to setup an interrupt request on the Isolate. The patch also deprecates ClearInterrupt API. As long as the interrupt handler is called outside of locks there's no way to guarantee that the handler will not be called after ClearInterrupt was invoked as it might have already started execution. Committed: https://crrev.com/87e4bba31eabfd3b12e42b5886dc9da08d2daf13 Cr-Commit-Position: refs/heads/master@{#25910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -50 lines) Patch
M include/v8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.h View 4 chunks +6 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +17 lines, -13 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +13 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
alph
ptal. The patch replaces https://codereview.chromium.org/812583003/
6 years ago (2014-12-19 14:31:48 UTC) #2
yurys
lgtm
6 years ago (2014-12-19 14:43:07 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-19 14:45:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796623003/1
6 years ago (2014-12-19 16:58:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/613)
6 years ago (2014-12-19 17:13:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796623003/1
6 years ago (2014-12-20 07:31:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-20 07:54:11 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-20 07:54:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87e4bba31eabfd3b12e42b5886dc9da08d2daf13
Cr-Commit-Position: refs/heads/master@{#25910}

Powered by Google App Engine
This is Rietveld 408576698