Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 796623002: Remove unused chrome.send's in Accessibility settings (Closed)

Created:
6 years ago by michaelpg
Modified:
6 years ago
Reviewers:
*stevenjb, yoshiki
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused chrome.send's in Accessibility settings These checkboxes were updated to correspond to prefs, so the C++ handlers were removed, but the JS event handlers stayed behind. BUG=crashes in Debug builds R=*stevenjb@chromium.org,yoshiki@chromium.org Committed: https://crrev.com/a87d4be36bda16140837b08f5bd32228cd66d286 Cr-Commit-Position: refs/heads/master@{#307856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
michaelpg
6 years ago (2014-12-10 23:38:00 UTC) #1
stevenjb
lgtm
6 years ago (2014-12-11 00:09:30 UTC) #2
yoshiki
LGTM. Thanks.
6 years ago (2014-12-11 03:13:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796623002/1
6 years ago (2014-12-11 03:16:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 04:09:49 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 04:10:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a87d4be36bda16140837b08f5bd32228cd66d286
Cr-Commit-Position: refs/heads/master@{#307856}

Powered by Google App Engine
This is Rietveld 408576698