Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 796573003: Make CSSStyleDeclaration function arguments non-optional (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make CSSStyleDeclaration function arguments non-optional http://dev.w3.org/csswg/cssom/#the-cssstyledeclaration-interface Firefox Nightly and IE11 pass the added tests, i.e. throw exceptions, making this change likely Web compatible. The nullability of argument and return types is still not per spec, but that's a separate issue. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186902

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
A LayoutTests/fast/css/cssom-missing-arguments.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/cssom-missing-arguments-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
update test
6 years ago (2014-12-10 23:41:20 UTC) #1
philipj_slow
PTAL
6 years ago (2014-12-10 23:41:40 UTC) #3
Timothy Loh
On 2014/12/10 23:41:40, philipj wrote: > PTAL lgtm
6 years ago (2014-12-10 23:44:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796573003/20001
6 years ago (2014-12-10 23:50:20 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 02:43:55 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186902

Powered by Google App Engine
This is Rietveld 408576698