fix for chrome bug with sub pixel hairlines

fix for chrome bug with sub pixel hairlines

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/bd528cdb51c4a64c2daead66f152b4034cebf752

[joshualitt, 2014-12-10 21:25:35]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2014-12-10 21:25:35]

Anything else in the GM we should have Brian?

[bsalomon, 2014-12-10 21:29:35]

https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp
File gm/subpixelpaths.cpp (right):

https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode2
gm/subpixelpaths.cpp:2: * Copyright 2013 Google Inc.
copyright date

https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode14
gm/subpixelpaths.cpp:14: class SubpixelPathsGM : public GM {
I'd call it thinstrokes or subpixelstrokes rather than subpixelpaths.

It looks like this is lifted from hairlines.cpp. Do you want to just modify and
perhaps rename that GM to test width = 0 as well as other widths?

https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode29
gm/subpixelpaths.cpp:29: // Arc example to test imperfect truncation bug
(crbug.com/295626)
??

[joshualitt, 2014-12-10 21:38:20]

On 2014/12/10 21:29:35, bsalomon wrote:
> https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp
> File gm/subpixelpaths.cpp (right):
> 
> https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode2
> gm/subpixelpaths.cpp:2: * Copyright 2013 Google Inc.
> copyright date
> 
>
https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode14
> gm/subpixelpaths.cpp:14: class SubpixelPathsGM : public GM {
> I'd call it thinstrokes or subpixelstrokes rather than subpixelpaths.
> 
> It looks like this is lifted from hairlines.cpp. Do you want to just modify
and
> perhaps rename that GM to test width = 0 as well as other widths?
> 
>
https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode29
> gm/subpixelpaths.cpp:29: // Arc example to test imperfect truncation bug
> (crbug.com/295626)
> ??

feedback inc

[bsalomon, 2014-12-10 21:45:27]

On 2014/12/10 21:38:20, joshualitt wrote:
> On 2014/12/10 21:29:35, bsalomon wrote:
> > https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp
> > File gm/subpixelpaths.cpp (right):
> > 
> >
https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode2
> > gm/subpixelpaths.cpp:2: * Copyright 2013 Google Inc.
> > copyright date
> > 
> >
>
https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode14
> > gm/subpixelpaths.cpp:14: class SubpixelPathsGM : public GM {
> > I'd call it thinstrokes or subpixelstrokes rather than subpixelpaths.
> > 
> > It looks like this is lifted from hairlines.cpp. Do you want to just modify
> and
> > perhaps rename that GM to test width = 0 as well as other widths?
> > 
> >
>
https://codereview.chromium.org/796573002/diff/1/gm/subpixelpaths.cpp#newcode29
> > gm/subpixelpaths.cpp:29: // Arc example to test imperfect truncation bug
> > (crbug.com/295626)
> > ??
> 
> feedback inc

lgtm, probably want to add this test to ignored-tests.txt before committing.

[joshualitt, 2014-12-10 22:14:21]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-12-10 22:14:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796573002/20001

[commit-bot: I haz the power, 2014-12-10 22:23:45]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bd528cdb51c4a64c2daead66f152b4034cebf752