Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2244)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 796543002: Plugin Power Saver: Implement option in Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "Fix" a browser test by disabling it. Fix a nit. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index b01676aa0cae5b22a12af93a9af67b7d71d52c86..7f0a5ef205b6af216bcecba20f5cfc85b3372ab2 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -2040,17 +2040,22 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderAlertAfterOnload) {
#if defined(USE_AURA) && !defined(OS_WIN)
Lei Zhang 2014/12/17 20:46:40 Ouch, this is pretty painful to look at. Essential
// http://crbug.com/103496
#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
+#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
#elif defined(OS_MACOSX)
// http://crbug.com/100514
#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
+#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
#elif defined(OS_WIN) && defined(ARCH_CPU_X86_64)
// TODO(jschuh): Failing plugin tests. crbug.com/244653
#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
+#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
#elif defined(OS_LINUX)
// http://crbug.com/306715
#define MAYBE_PrerenderDelayLoadPlugin DISABLED_PrerenderDelayLoadPlugin
+#define MAYBE_PrerenderPluginPowerSaver DISABLED_PrerenderPluginPowerSaver
#else
#define MAYBE_PrerenderDelayLoadPlugin PrerenderDelayLoadPlugin
+#define MAYBE_PrerenderPluginPowerSaver PrerenderPluginPowerSaver
#endif
// http://crbug.com/306715
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, MAYBE_PrerenderDelayLoadPlugin) {
@@ -2060,18 +2065,17 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, MAYBE_PrerenderDelayLoadPlugin) {
NavigateToDestURL();
}
-// Checks that plugins are not loaded on prerendering pages when click-to-play
-// is enabled.
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderClickToPlay) {
+// For enabled Plugin Power Saver, checks that plugins are not loaded while
+// a page is being preloaded, but are loaded when the page is displayed.
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, MAYBE_PrerenderPluginPowerSaver) {
// Enable click-to-play.
HostContentSettingsMap* content_settings_map =
current_browser()->profile()->GetHostContentSettingsMap();
content_settings_map->SetDefaultContentSetting(
- CONTENT_SETTINGS_TYPE_PLUGINS, CONTENT_SETTING_ASK);
+ CONTENT_SETTINGS_TYPE_PLUGINS, CONTENT_SETTING_DETECT_IMPORTANT_CONTENT);
- PrerenderTestURL("files/prerender/prerender_plugin_click_to_play.html",
- FINAL_STATUS_USED,
- 1);
+ PrerenderTestURL("files/prerender/prerender_plugin_power_saver.html",
+ FINAL_STATUS_USED, 1);
NavigateToDestURL();
}
« no previous file with comments | « chrome/browser/plugins/plugin_info_message_filter_unittest.cc ('k') | chrome/browser/resources/options/content_settings.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698