runtime/vm/flow_graph_optimizer.h - Issue 79653002: Merge TRUNCDIV and MOD into one instruction. Icorporated feedback from CL https://codereview.chromi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 79653002: Merge TRUNCDIV and MOD into one instruction. Icorporated feedback from CL https://codereview.chromi… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.h

===================================================================

--- runtime/vm/flow_graph_optimizer.h (revision 30526)

+++ runtime/vm/flow_graph_optimizer.h (working copy)

@@ -31,7 +31,8 @@

// Optimize (a << b) & c pattern: if c is a positive Smi or zero, then the

// shift can be a truncating Smi shift-left and result is always Smi.

- void TryOptimizeLeftShiftWithBitAndPattern();

+ // Merge instructions (only per basic-block).

+ void TryOptimizePatterns();

// Returns true if any instructions were canonicalized away.

bool Canonicalize();

@@ -203,6 +204,7 @@

void OptimizeLeftShiftBitAndSmiOp(Definition* bit_and_instr,

Definition* left_instr,

Definition* right_instr);

+ void TryMergeTruncDivMod(GrowableArray<BinarySmiOpInstr*>* merge_candidates);

FlowGraph* flow_graph_;

« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »