runtime/vm/compiler.cc - Issue 79653002: Merge TRUNCDIV and MOD into one instruction. Icorporated feedback from CL https://codereview.chromi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 79653002: Merge TRUNCDIV and MOD into one instruction. Icorporated feedback from CL https://codereview.chromi… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

===================================================================

--- runtime/vm/compiler.cc (revision 30526)

+++ runtime/vm/compiler.cc (working copy)

@@ -336,11 +336,11 @@

optimizer.ApplyICData();

DEBUG_ASSERT(flow_graph->VerifyUseLists());

- // Optimize (a << b) & c patterns. Must occur before

+ // Optimize (a << b) & c patterns, merge operations. Must occur before

// 'SelectRepresentations' which inserts conversion nodes.

// TODO(srdjan): Moved before inlining until environment use list can

// be used to detect when shift-left is outside the scope of bit-and.

- optimizer.TryOptimizeLeftShiftWithBitAndPattern();

+ optimizer.TryOptimizePatterns();

DEBUG_ASSERT(flow_graph->VerifyUseLists());

// Inlining (mutates the flow graph)

« no previous file with comments | « no previous file | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »