Merge TRUNCDIV and MOD into one instruction. Icorporated feedback from CL https://codereview.chromi…

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 4024 matching lines @@
     __ jmp(&skip_call, Assembler::kNearJump);
   }
   __ Bind(&do_call);
   __ CallRuntime(TargetFunction(), InputCount());
   __ movaps(locs()->out().fpu_reg(), XMM0);
   __ Bind(&skip_call);
   __ leave();
 }
 
 
+LocationSummary* MergedMathInstr::MakeLocationSummary() const {
+  if (kind() == MergedMathInstr::kTruncDivMod) {
+    const intptr_t kNumInputs = 2;
+    const intptr_t kNumTemps = 1;
+    LocationSummary* summary =
+        new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
+    // Both inputs must be writable because they will be untagged.
+    summary->set_in(0, Location::RegisterLocation(RAX));
+    summary->set_in(1, Location::WritableRegister());
+    summary->set_out(Location::RequiresRegister());
+    // Will be used for sign extension and division.
+    summary->set_temp(0, Location::RegisterLocation(RDX));
+    return summary;
+  }
+  UNIMPLEMENTED();
+  return NULL;
+}
+
+
+void MergedMathInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  Label* deopt = NULL;
+  if (CanDeoptimize()) {
+    deopt  = compiler->AddDeoptStub(deopt_id(), kDeoptBinarySmiOp);
+  }
+  if (kind() == MergedMathInstr::kTruncDivMod) {
+    Register left = locs()->in(0).reg();
+    Register right = locs()->in(1).reg();
+    Register result = locs()->out().reg();
+    Label not_32bit, done;
+    Register temp = locs()->temp(0).reg();
+    ASSERT(left == RAX);
+    ASSERT((right != RDX) && (right != RAX));
+    ASSERT(temp == RDX);
+    ASSERT((result != RDX) && (result != RAX));
+    // Handle divide by zero in runtime.
+    __ testq(right, right);
+    __ j(ZERO, deopt);
+    // Check if both operands fit into 32bits as idiv with 64bit operands
+    // requires twice as many cycles and has much higher latency.
+    // We are checking this before untagging them to avoid corner case
+    // dividing INT_MAX by -1 that raises exception because quotient is
+    // too large for 32bit register.
+    __ movsxd(temp, left);
+    __ cmpq(temp, left);
+    __ j(NOT_EQUAL, &not_32bit);
+    __ movsxd(temp, right);
+    __ cmpq(temp, right);
+    __ j(NOT_EQUAL, &not_32bit);
+
+    // Both operands are 31bit smis. Divide using 32bit idiv.
+    __ SmiUntag(left);
+    __ SmiUntag(right);
+    __ cdq();
+    __ idivl(right);
+    __ movsxd(RAX, RAX);
+    __ movsxd(RDX, RDX);
+    __ jmp(&done);
+
+    // Divide using 64bit idiv.
+    __ Bind(&not_32bit);
+    __ SmiUntag(left);
+    __ SmiUntag(right);
+    __ cqo();  // Sign extend RAX -> RDX:RAX.
+    __ idivq(right);  //  RAX: quotient, RDX: remainder.
+    // Check the corner case of dividing the 'MIN_SMI' with -1, in which
+    // case we cannot tag the result.
+    __ CompareImmediate(RAX, Immediate(0x4000000000000000), PP);
+    __ j(EQUAL, deopt);
+    __ Bind(&done);
+
+    // Modulo correction (RDX).
+    //  res = left % right;
+    //  if (res < 0) {
+    //    if (right < 0) {
+    //      res = res - right;
+    //    } else {
+    //      res = res + right;
+    //    }
+    //  }
+    Label subtract, all_done;
+    __ cmpq(RDX, Immediate(0));
+    __ j(GREATER_EQUAL, &all_done, Assembler::kNearJump);
+    // Result is negative, adjust it.
+    __ cmpq(right, Immediate(0));
+    __ j(LESS, &subtract, Assembler::kNearJump);
+    __ addq(RDX, right);
+    __ jmp(&all_done, Assembler::kNearJump);
+    __ Bind(&subtract);
+    __ subq(RDX, right);
+    __ Bind(&all_done);
+    __ SmiTag(result);
+
+    __ LoadObject(result, Array::ZoneHandle(Array::New(2, Heap::kOld)), PP);
+    const intptr_t index_scale = FlowGraphCompiler::ElementSizeFor(kArrayCid);
+    Address trunc_div_address(
+        FlowGraphCompiler::ElementAddressForIntIndex(kArrayCid,
+                                                     index_scale,
+                                                     result,
+                                                     0));
+    Address mod_address(
+        FlowGraphCompiler::ElementAddressForIntIndex(kArrayCid,
+                                                     index_scale,
+                                                     result,
+                                                     1));
+    __ SmiTag(RAX);
+    __ SmiTag(RDX);
+    __ StoreIntoObjectNoBarrier(result, trunc_div_address, RAX);
+    __ StoreIntoObjectNoBarrier(result, mod_address, RDX);
+    // FLAG_throw_on_javascript_int_overflow: not needed.
+    // Note that the result of an integer division/modulo of two
+    // in-range arguments, cannot create out-of-range result.
+    return;
+  }
+  UNIMPLEMENTED();
+}
+
+
 LocationSummary* PolymorphicInstanceCallInstr::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Label* deopt = compiler->AddDeoptStub(deopt_id(),
                                         kDeoptPolymorphicInstanceCallTestFail);
   if (ic_data().NumberOfChecks() == 0) {
     __ jmp(deopt);
@@ skipping 517 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64