Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 796523002: Force embedding full font when serializing pictures. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
bungeman-skia, mtklein, *reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Force embedding full font when serializing pictures. We can't do this unconditionally or pipe will become stupidly slow. DM's serialize mode fails subtly on Mac when we force embedding, so I've #ifdef'd that away. Other platforms look fine. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1a4900e8be6086a824488dc98d4822e440815657

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't embed on Macs. #

Patch Set 3 : new method #

Patch Set 4 : Whitelist Linux instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M include/core/SkTypeface.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
mtklein
6 years ago (2014-12-10 20:17:58 UTC) #2
bungeman-skia
Other than my reedgiest, lgtm. https://codereview.chromium.org/796523002/diff/1/include/core/SkTypeface.h File include/core/SkTypeface.h (right): https://codereview.chromium.org/796523002/diff/1/include/core/SkTypeface.h#newcode139 include/core/SkTypeface.h:139: void serialize(SkWStream*, bool forceEmbedding=false) ...
6 years ago (2014-12-10 20:49:31 UTC) #4
mtklein
+reed, want to take a look?
6 years ago (2014-12-10 21:56:59 UTC) #6
mtklein
Now as a separate method.
6 years ago (2014-12-10 22:26:12 UTC) #7
reed1
lgtm
6 years ago (2014-12-11 14:45:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796523002/40001
6 years ago (2014-12-11 14:55:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796523002/60001
6 years ago (2014-12-11 18:18:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796523002/60001
6 years ago (2014-12-11 19:05:50 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-11 19:06:05 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/1a4900e8be6086a824488dc98d4822e440815657

Powered by Google App Engine
This is Rietveld 408576698