Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 796503002: Create optimized versions of the Map/Set clear method (Closed)

Created:
6 years ago by adamk
Modified:
6 years ago
CC:
v8-dev, arv (Not doing code reviews), rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Create optimized versions of the Map/Set clear method This completes the first round of optimizations for Map and Set. All non-key-dependent methods now have a Hydrogen version, and for keyed methods, string versions are optimized.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -13 lines) Patch
M src/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +8 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
6 years ago (2014-12-10 19:27:28 UTC) #2
Dmitry Lomov (no reviews)
nice! lgtm
6 years ago (2014-12-10 19:29:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796503002/1
6 years ago (2014-12-10 21:49:53 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 22:16:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698