Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5765)

Unified Diff: chrome/browser/shell_integration_linux.cc

Issue 796493006: Update shell_integration_linux to use the new version of LaunchProcess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/shell_integration_linux.cc
diff --git a/chrome/browser/shell_integration_linux.cc b/chrome/browser/shell_integration_linux.cc
index 1ef2bd7b2f136057e97048e2692d4fb53214cf61..886ca5134109438ff34c3ec2a423d87fcb637c8f 100644
--- a/chrome/browser/shell_integration_linux.cc
+++ b/chrome/browser/shell_integration_linux.cc
@@ -75,16 +75,16 @@ bool LaunchXdgUtility(const std::vector<std::string>& argv, int* exit_code) {
base::FileHandleMappingVector no_stdin;
no_stdin.push_back(std::make_pair(devnull, STDIN_FILENO));
- base::ProcessHandle handle;
base::LaunchOptions options;
options.fds_to_remap = &no_stdin;
- if (!base::LaunchProcess(argv, options, &handle)) {
+ base::Process process = base::LaunchProcess(argv, options);
+ if (!process.IsValid()) {
close(devnull);
return false;
}
close(devnull);
- return base::WaitForExitCode(handle, exit_code);
+ return process.WaitForExit(exit_code);
}
std::string CreateShortcutIcon(const gfx::ImageFamily& icon_images,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698