Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test and fix code Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 5ad1628d558e14fe4860fb3e87a27c57145204f9..c9627e9a8ff64fb2f412c3589baedbf4a45e177e 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -928,9 +928,8 @@ void PasswordAutofillAgent::DidStopLoading() {
did_stop_loading_ = true;
}
-void PasswordAutofillAgent::FrameDetached(blink::WebFrame* frame) {
- if (frame == render_frame()->GetWebFrame())
- FrameClosing();
+void PasswordAutofillAgent::FrameDetached() {
+ FrameClosing();
}
void PasswordAutofillAgent::WillSendSubmitEvent(
@@ -1318,9 +1317,4 @@ void PasswordAutofillAgent::LegacyPasswordAutofillAgent::
agent_->LegacyDidStartProvisionalLoad(navigated_frame);
}
-void PasswordAutofillAgent::LegacyPasswordAutofillAgent::FrameDetached(
- blink::WebFrame* frame) {
- agent_->FrameDetached(frame);
-}
-
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698