Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: components/autofill/content/browser/request_autocomplete_manager.h

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test and fix code Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/request_autocomplete_manager.h
diff --git a/components/autofill/content/browser/request_autocomplete_manager.h b/components/autofill/content/browser/request_autocomplete_manager.h
index 648fae7a8451fb77d5117b851f93283fdb649eed..131c242905451d24cc80e3fc35c85b75c8af989a 100644
--- a/components/autofill/content/browser/request_autocomplete_manager.h
+++ b/components/autofill/content/browser/request_autocomplete_manager.h
@@ -23,12 +23,9 @@ class RequestAutocompleteManager {
explicit RequestAutocompleteManager(ContentAutofillDriver* autofill_driver);
~RequestAutocompleteManager();
- // Requests an interactive autocomplete UI to be shown for |frame_url| with
- // |form|.
- void OnRequestAutocomplete(const FormData& form, const GURL& frame_url);
-
- // Requests that any running interactive autocomplete be cancelled.
- void OnCancelRequestAutocomplete();
+ // Requests an interactive autocomplete UI to be shown for the associated
+ // frame.
+ void OnRequestAutocomplete(const FormData& form);
private:
// Tells the renderer that the current interactive autocomplete dialog
@@ -44,7 +41,6 @@ class RequestAutocompleteManager {
// and calls |callback| once the interaction is complete.
void ShowRequestAutocompleteDialog(
const FormData& form,
- const GURL& source_url,
const AutofillClient::ResultCallback& callback);
// The autofill driver owns and outlives |this|.

Powered by Google App Engine
This is Rietveld 408576698