Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 796433003: MacViews: Don't draw custom frame on Mac (Closed)

Created:
5 years, 11 months ago by Andre
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@keybinding3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Don't draw custom frame on Mac We don't want to draw custom titlebar and borders on Mac. Change BrowserFrame to delegate UseCustomFrame() to NativeBrowserFrame, and provide appropriate overrides for the platforms: Mac -> false Win, ChromeOS -> true Desktop Linux -> follow user pref Consolidate Desktop Linux specific code into DesktopBrowserFrameAuraLinux. BUG=425229 Committed: https://crrev.com/70af3549366e24509cf05e6903a8431ba8af037b Cr-Commit-Position: refs/heads/master@{#311600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -63 lines) Patch
M chrome/browser/ui/views/frame/browser_frame.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 4 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_ash.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_ash.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 3 chunks +5 lines, -36 lines 0 comments Download
A chrome/browser/ui/views/frame/desktop_browser_frame_auralinux.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/frame/desktop_browser_frame_auralinux.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/native_browser_frame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/native_browser_frame_factory_auralinux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
sky@ please review.
5 years, 11 months ago (2015-01-14 22:50:49 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-15 01:11:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796433003/1
5 years, 11 months ago (2015-01-15 01:13:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 01:18:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 01:19:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70af3549366e24509cf05e6903a8431ba8af037b
Cr-Commit-Position: refs/heads/master@{#311600}

Powered by Google App Engine
This is Rietveld 408576698