Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 796433002: Revert of Migrate DeviceUtils.ReadFile to adb_wrapper (Closed)

Created:
6 years ago by perezju
Modified:
6 years ago
Reviewers:
jbudorick, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate DeviceUtils.ReadFile to adb_wrapper (patchset #6 id:100001 of https://codereview.chromium.org/775333002/) Reason for revert: Broke telemetry android_browser_backend due to missing client change Original issue's description: > Migrate DeviceUtils.ReadFile to adb_wrapper > > The implementation is based on a simple 'cat' run by shell on the > device (with optional as_root). > > Interface changes: > - The return value is a string (instead of a list of lines). > - An exception is raised if the file cannot be read (instead of returning an empty list). > > BUG=267773 > > Committed: https://crrev.com/c75a264a0386df5931a9b6ac8c81337794d034d0 > Cr-Commit-Position: refs/heads/master@{#307672} TBR=jbudorick@chromium.org,skyostil@chromium.org NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/dc3b7db40fa6f66cd5757b2e807493a91379dc7f Cr-Commit-Position: refs/heads/master@{#307711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -73 lines) Patch
M build/android/pylib/device/device_utils.py View 3 chunks +17 lines, -20 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 2 chunks +42 lines, -19 lines 0 comments Download
M build/android/pylib/flag_changer.py View 3 chunks +5 lines, -8 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/pylib/perf/thermal_throttle.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/tombstones.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py View 2 chunks +5 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
perezju
Created Revert of Migrate DeviceUtils.ReadFile to adb_wrapper
6 years ago (2014-12-10 16:07:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796433002/1
6 years ago (2014-12-10 16:08:59 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-10 16:09:01 UTC) #4
jbudorick
lgtm :(
6 years ago (2014-12-10 16:10:03 UTC) #5
Sami
On 2014/12/10 16:10:03, jbudorick wrote: > lgtm :( lgtm x2
6 years ago (2014-12-10 16:11:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796433002/1
6 years ago (2014-12-10 16:12:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-10 16:14:02 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-10 16:15:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc3b7db40fa6f66cd5757b2e807493a91379dc7f
Cr-Commit-Position: refs/heads/master@{#307711}

Powered by Google App Engine
This is Rietveld 408576698