Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 796423003: Check that all symbolized methods in the output orderfile are in their own linker section in the or… (Closed)

Created:
6 years ago by azarchs
Modified:
6 years ago
Reviewers:
pasko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that all symbolized methods in the output orderfile are in their own linker section in the original object files. BUG=440018 Committed: https://crrev.com/5a17b565c9dcf965c0942a06a0b6595c2699f938 Cr-Commit-Position: refs/heads/master@{#308099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -20 lines) Patch
M tools/cygprofile/symbolize.py View 6 chunks +88 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
azarchs
Replacing https://codereview.chromium.org/784333002/, which I failed to rebase properly.
6 years ago (2014-12-12 15:30:49 UTC) #2
pasko
lgtm assuming it's a trivial rebase
6 years ago (2014-12-12 15:37:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796423003/1
6 years ago (2014-12-12 15:40:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 16:31:49 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 16:32:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a17b565c9dcf965c0942a06a0b6595c2699f938
Cr-Commit-Position: refs/heads/master@{#308099}

Powered by Google App Engine
This is Rietveld 408576698