Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 796403002: Renable v8.garbage_collection_cases on all platforms but windows (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renable v8.garbage_collection_cases on all platforms but windows On windows, we don't get thread times, so the benchmark doesn't work R=ernstm@chromium.org,tonyg@chromium.org BUG=416502 Committed: https://crrev.com/e1b1d20883dc16bea1776f05f1dde764a054f4cb Cr-Commit-Position: refs/heads/master@{#308366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/v8.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-12 13:47:10 UTC) #1
jochen (gone - plz use gerrit)
tryjobs here: android: https://codereview.chromium.org/797973002 mac: https://codereview.chromium.org/798953002 linux: https://codereview.chromium.org/797263002 ptal
6 years ago (2014-12-12 13:54:13 UTC) #2
sullivan
lgtm
6 years ago (2014-12-15 15:29:43 UTC) #4
nednguyen
lgtm
6 years ago (2014-12-15 15:45:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796403002/1
6 years ago (2014-12-15 15:46:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 17:28:35 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-15 17:29:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1b1d20883dc16bea1776f05f1dde764a054f4cb
Cr-Commit-Position: refs/heads/master@{#308366}

Powered by Google App Engine
This is Rietveld 408576698