Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 796393005: Cleanup: Remove if (!CurrentlyOn()) PostTask() pattern in EmbeddedWorkerInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 5f1f1cdc372776c8b59406ea2cc89b9abe389a48..7523e6d0a4f6fb46c85ef2e5212306a97a13dcda 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -101,9 +101,7 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
Status status() const { return status_; }
int process_id() const { return process_id_; }
int thread_id() const { return thread_id_; }
- int worker_devtools_agent_route_id() const {
- return worker_devtools_agent_route_id_;
- }
+ int worker_devtools_agent_route_id() const;
MessagePortMessageFilter* message_port_message_filter() const;
void AddListener(Listener* listener);
@@ -113,7 +111,7 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
private:
typedef ObserverList<Listener> ListenerList;
-
+ class DevToolsProxy;
friend class EmbeddedWorkerRegistry;
FRIEND_TEST_ALL_PREFIXES(EmbeddedWorkerInstanceTest, StartAndStop);
@@ -197,14 +195,13 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
// Current running information. -1 indicates the worker is not running.
int process_id_;
int thread_id_;
- int worker_devtools_agent_route_id_;
// Whether devtools is attached or not.
bool devtools_attached_;
StatusCallback start_callback_;
-
ListenerList listener_list_;
+ scoped_ptr<DevToolsProxy> devtools_proxy_;
base::WeakPtrFactory<EmbeddedWorkerInstance> weak_factory_;
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698