Cleanup: Remove if (!CurrentlyOn()) PostTask() pattern in EmbeddedWorkerInstance

content/browser/service_worker/embedded_worker_instance.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/embedded_worker_instance.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/debug/trace_event.h"
+#include "base/threading/non_thread_safe.h"
 #include "content/browser/devtools/service_worker_devtools_manager.h"
 #include "content/browser/service_worker/embedded_worker_registry.h"
 #include "content/browser/service_worker/service_worker_context_core.h"
 #include "content/common/service_worker/embedded_worker_messages.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "ipc/ipc_message.h"
 #include "url/gurl.h"
 
 namespace content {
 
 namespace {
 
 // Functor to sort by the .second element of a struct.
 struct SecondGreater {
   template <typename Value>
   bool operator()(const Value& lhs, const Value& rhs) {
     return lhs.second > rhs.second;
   }
 };
 
-void NotifyWorkerReadyForInspection(int worker_process_id,
-                                    int worker_route_id) {
-  if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
-    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-    BrowserThread::PostTask(BrowserThread::UI,
-                            FROM_HERE,
-                            base::Bind(NotifyWorkerReadyForInspection,
-                                       worker_process_id,
-                                       worker_route_id));
-    return;
-  }
+void NotifyWorkerReadyForInspectionOnUI(int worker_process_id,
+                                        int worker_route_id) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   ServiceWorkerDevToolsManager::GetInstance()->WorkerReadyForInspection(
       worker_process_id, worker_route_id);
 }
 
-void NotifyWorkerDestroyed(int worker_process_id, int worker_route_id) {
-  if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
-    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-    BrowserThread::PostTask(
-        BrowserThread::UI,
-        FROM_HERE,
-        base::Bind(NotifyWorkerDestroyed, worker_process_id, worker_route_id));
-    return;
-  }
+void NotifyWorkerDestroyedOnUI(int worker_process_id, int worker_route_id) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   ServiceWorkerDevToolsManager::GetInstance()->WorkerDestroyed(
       worker_process_id, worker_route_id);
 }
 
-void NotifyWorkerStopIgnored(int worker_process_id, int worker_route_id) {
-  if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
-    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-    BrowserThread::PostTask(BrowserThread::UI,
-                            FROM_HERE,
-                            base::Bind(NotifyWorkerStopIgnored,
-                                       worker_process_id,
-                                       worker_route_id));
-    return;
-  }
+void NotifyWorkerStopIgnoredOnUI(int worker_process_id, int worker_route_id) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   ServiceWorkerDevToolsManager::GetInstance()->WorkerStopIgnored(
       worker_process_id, worker_route_id);
 }
 
-
-void RegisterToWorkerDevToolsManager(
+void RegisterToWorkerDevToolsManagerOnUI(
     int process_id,
     const ServiceWorkerContextCore* service_worker_context,
-    base::WeakPtr<ServiceWorkerContextCore> service_worker_context_weak,
+    const base::WeakPtr<ServiceWorkerContextCore>& service_worker_context_weak,
     int64 service_worker_version_id,
     const GURL& url,
     const base::Callback<void(int worker_devtools_agent_route_id,
                               bool wait_for_debugger)>& callback) {
-  if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
-    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-    BrowserThread::PostTask(BrowserThread::UI,
-                            FROM_HERE,
-                            base::Bind(RegisterToWorkerDevToolsManager,
-                                       process_id,
-                                       service_worker_context,
-                                       service_worker_context_weak,
-                                       service_worker_version_id,
-                                       url,
-                                       callback));
-    return;
-  }
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   int worker_devtools_agent_route_id = MSG_ROUTING_NONE;
   bool wait_for_debugger = false;
   if (RenderProcessHost* rph = RenderProcessHost::FromID(process_id)) {
     // |rph| may be NULL in unit tests.
     worker_devtools_agent_route_id = rph->GetNextRoutingID();
     wait_for_debugger =
         ServiceWorkerDevToolsManager::GetInstance()->WorkerCreated(
             process_id,
             worker_devtools_agent_route_id,
             ServiceWorkerDevToolsManager::ServiceWorkerIdentifier(
                 service_worker_context,
                 service_worker_context_weak,
                 service_worker_version_id,
                 url));
   }
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(callback, worker_devtools_agent_route_id, wait_for_debugger));
 }
 
 }  // namespace
 
+// Lives on IO thread, proxies notifications to DevToolsManager that lives on
+// UI thread. Owned by EmbeddedWorkerInstance.
+class EmbeddedWorkerInstance::DevToolsProxy : public base::NonThreadSafe {
+ public:
+  DevToolsProxy(int process_id, int agent_route_id)
+      : process_id_(process_id),
+        agent_route_id_(agent_route_id) {}
+
+  ~DevToolsProxy() {
+    BrowserThread::PostTask(
+        BrowserThread::UI,
+        FROM_HERE,
+        base::Bind(NotifyWorkerDestroyedOnUI,
+                   process_id_, agent_route_id_));
+  }
+
+  void NotifyWorkerReadyForInspection() {
+    DCHECK(CalledOnValidThread());
+    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+                            base::Bind(NotifyWorkerReadyForInspectionOnUI,
+                                       process_id_, agent_route_id_));
+  }
+
+  void NotifyWorkerStopIgnored() {
+    DCHECK(CalledOnValidThread());
+    BrowserThread::PostTask(BrowserThread::UI,
+                            FROM_HERE,
+                            base::Bind(NotifyWorkerStopIgnoredOnUI,
+                                       process_id_, agent_route_id_));
+  }
+
+  int agent_route_id() const { return agent_route_id_; }
+
+ private:
+  const int process_id_;
+  const int agent_route_id_;
+  DISALLOW_COPY_AND_ASSIGN(DevToolsProxy);
+};
+
 EmbeddedWorkerInstance::~EmbeddedWorkerInstance() {
   if (status_ == STARTING || status_ == RUNNING)
     Stop();
-  if (worker_devtools_agent_route_id_ != MSG_ROUTING_NONE)
-    NotifyWorkerDestroyed(process_id_, worker_devtools_agent_route_id_);
+  devtools_proxy_.reset();
   if (context_ && process_id_ != -1)
     context_->process_manager()->ReleaseWorkerProcess(embedded_worker_id_);
   registry_->RemoveWorker(process_id_, embedded_worker_id_);
 }
 
 void EmbeddedWorkerInstance::Start(int64 service_worker_version_id,
                                    const GURL& scope,
                                    const GURL& script_url,
                                    bool pause_after_download,
                                    const StatusCallback& callback) {
@@ skipping 32 matching lines @@
   DCHECK(status_ == STARTING || status_ == RUNNING);
   ServiceWorkerStatusCode status =
       registry_->StopWorker(process_id_, embedded_worker_id_);
   if (status == SERVICE_WORKER_OK)
     status_ = STOPPING;
   return status;
 }
 
 void EmbeddedWorkerInstance::StopIfIdle() {
   if (devtools_attached_) {
-    NotifyWorkerStopIgnored(process_id_, worker_devtools_agent_route_id_);
+    if (devtools_proxy_)
+      devtools_proxy_->NotifyWorkerStopIgnored();
     return;
   }
   Stop();
 }
 
 void EmbeddedWorkerInstance::ResumeAfterDownload() {
   DCHECK_EQ(STARTING, status_);
   registry_->Send(
       process_id_,
       new EmbeddedWorkerMsg_ResumeAfterDownload(embedded_worker_id_));
@@ skipping 11 matching lines @@
 
 EmbeddedWorkerInstance::EmbeddedWorkerInstance(
     base::WeakPtr<ServiceWorkerContextCore> context,
     int embedded_worker_id)
     : context_(context),
       registry_(context->embedded_worker_registry()),
       embedded_worker_id_(embedded_worker_id),
       status_(STOPPED),
       process_id_(-1),
       thread_id_(kInvalidEmbeddedWorkerThreadId),
-      worker_devtools_agent_route_id_(MSG_ROUTING_NONE),
       devtools_attached_(false),
       weak_factory_(this) {
 }
 
 // static
 void EmbeddedWorkerInstance::RunProcessAllocated(
     base::WeakPtr<EmbeddedWorkerInstance> instance,
     base::WeakPtr<ServiceWorkerContextCore> context,
     scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params,
     const EmbeddedWorkerInstance::StatusCallback& callback,
@@ skipping 26 matching lines @@
                          params.get(),
                          "Status", status);
   if (status != SERVICE_WORKER_OK) {
     status_ = STOPPED;
     callback.Run(status);
     return;
   }
   const int64 service_worker_version_id = params->service_worker_version_id;
   process_id_ = process_id;
   GURL script_url(params->script_url);
-  RegisterToWorkerDevToolsManager(
-      process_id,
-      context_.get(),
-      context_,
-      service_worker_version_id,
-      script_url,
-      base::Bind(&EmbeddedWorkerInstance::SendStartWorker,
-                 weak_factory_.GetWeakPtr(),
-                 base::Passed(&params),
-                 callback));
+
+  // Register this worker to DevToolsManager on UI thread, then continue to
+  // call SendStartWorker on IO thread.
+  BrowserThread::PostTask(
+      BrowserThread::UI,
+      FROM_HERE,
+      base::Bind(RegisterToWorkerDevToolsManagerOnUI,
+                 process_id_,
+                 context_.get(),
+                 context_,
+                 service_worker_version_id,
+                 script_url,
+                 base::Bind(&EmbeddedWorkerInstance::SendStartWorker,
+                            weak_factory_.GetWeakPtr(),
+                            base::Passed(&params),
+                            callback)));
 }
 
 void EmbeddedWorkerInstance::SendStartWorker(
     scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params,
     const StatusCallback& callback,
     int worker_devtools_agent_route_id,
     bool wait_for_debugger) {
-  worker_devtools_agent_route_id_ = worker_devtools_agent_route_id;
+  if (worker_devtools_agent_route_id != MSG_ROUTING_NONE) {
+    DCHECK(!devtools_proxy_);
+    devtools_proxy_.reset(new DevToolsProxy(process_id_,
+                                            worker_devtools_agent_route_id));
+  }
   params->worker_devtools_agent_route_id = worker_devtools_agent_route_id;
   params->wait_for_debugger = wait_for_debugger;
   ServiceWorkerStatusCode status =
       registry_->SendStartWorker(params.Pass(), process_id_);
   if (status != SERVICE_WORKER_OK) {
     callback.Run(status);
     return;
   }
   DCHECK(start_callback_.is_null());
   start_callback_ = callback;
 }
 
 void EmbeddedWorkerInstance::OnReadyForInspection() {
-  if (worker_devtools_agent_route_id_ != MSG_ROUTING_NONE)
-    NotifyWorkerReadyForInspection(process_id_,
-                                   worker_devtools_agent_route_id_);
+  if (devtools_proxy_)
+    devtools_proxy_->NotifyWorkerReadyForInspection();
 }
 
 void EmbeddedWorkerInstance::OnScriptLoaded(int thread_id) {
   thread_id_ = thread_id;
 }
 
 void EmbeddedWorkerInstance::OnScriptLoadFailed() {
 }
 
 void EmbeddedWorkerInstance::OnScriptEvaluated(bool success) {
   DCHECK(!start_callback_.is_null());
   start_callback_.Run(success ? SERVICE_WORKER_OK
                               : SERVICE_WORKER_ERROR_START_WORKER_FAILED);
   start_callback_.Reset();
 }
 
 void EmbeddedWorkerInstance::OnStarted() {
   // Stop is requested before OnStarted is sent back from the worker.
   if (status_ == STOPPING)
     return;
   DCHECK(status_ == STARTING);
   status_ = RUNNING;
   FOR_EACH_OBSERVER(Listener, listener_list_, OnStarted());
 }
 
 void EmbeddedWorkerInstance::OnStopped() {
-  if (worker_devtools_agent_route_id_ != MSG_ROUTING_NONE)
-    NotifyWorkerDestroyed(process_id_, worker_devtools_agent_route_id_);
+  devtools_proxy_.reset();
   if (context_)
     context_->process_manager()->ReleaseWorkerProcess(embedded_worker_id_);
   Status old_status = status_;
   status_ = STOPPED;
   process_id_ = -1;
   thread_id_ = -1;
-  worker_devtools_agent_route_id_ = MSG_ROUTING_NONE;
   start_callback_.Reset();
   FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped(old_status));
 }
 
 void EmbeddedWorkerInstance::OnPausedAfterDownload() {
   // Stop can be requested before getting this far.
   if (status_ == STOPPING)
     return;
   DCHECK(status_ == STARTING);
   FOR_EACH_OBSERVER(Listener, listener_list_, OnPausedAfterDownload());
@@ skipping 25 matching lines @@
     const base::string16& message,
     int line_number,
     const GURL& source_url) {
   FOR_EACH_OBSERVER(
       Listener,
       listener_list_,
       OnReportConsoleMessage(
           source_identifier, message_level, message, line_number, source_url));
 }
 
+int EmbeddedWorkerInstance::worker_devtools_agent_route_id() const {
+  if (devtools_proxy_)
+    return devtools_proxy_->agent_route_id();
+  return MSG_ROUTING_NONE;
+}
+
 MessagePortMessageFilter* EmbeddedWorkerInstance::message_port_message_filter()
     const {
   return registry_->MessagePortMessageFilterForProcess(process_id_);
 }
 
 void EmbeddedWorkerInstance::AddListener(Listener* listener) {
   listener_list_.AddObserver(listener);
 }
 
 void EmbeddedWorkerInstance::RemoveListener(Listener* listener) {
   listener_list_.RemoveObserver(listener);
 }
 
 }  // namespace content