Issue 796363002: Fixed an ordering issue found by UBSan_vptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 796363002: Fixed an ordering issue found by UBSan_vptr. (Closed)

Created:
6 years ago by Sven Panne

Modified:
6 years ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fixed an ordering issue found by UBSan_vptr. We managed to access the scope_ member of CompilationInfo before its containing object was actually constructed. Rule of thumb: When constructing an object, never ever pass around pointers to members which come later in the member initializer list, you simply can't see locally if this might cause trouble or not.

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	src/code-stubs-hydrogen.cc	View		7 chunks	+15 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796363002/1

6 years ago (2014-12-12 12:09:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages