Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 796343002: win: use __debugbreak instead of __asm__ int3 (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@file_path
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/logging.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scottmg
(This is the last of the set to get 'base' building in Debug and Release ...
6 years ago (2014-12-12 08:10:55 UTC) #2
Mark Mentovai
LGTM. Great work getting this going!
6 years ago (2014-12-12 14:35:01 UTC) #3
scottmg
6 years ago (2014-12-12 18:34:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
e76f47edc018881fea8e02d3d7eda5c325df70d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698