Issue 796333005: final circles?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 796333005: final circles? (Closed)

Created:
6 years ago by bsalomon

Modified:
6 years ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

final circles? Committed: https://skia.googlesource.com/skia/+/e23f20e320a7b3ef27f2cd7b1a12d70ef80b31be

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+202 lines, -274 lines)			Patch
M	expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Release/expected-results.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json	View	11 chunks	+17 lines, -15 lines	0 comments	Download
M	expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Debug/expected-results.json	View	4 chunks	+8 lines, -14 lines	0 comments	Download
M	expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Release/expected-results.json	View	4 chunks	+8 lines, -14 lines	0 comments	Download
M	expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json	View	5 chunks	+11 lines, -9 lines	0 comments	Download
M	expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Debug/expected-results.json	View	9 chunks	+10 lines, -10 lines	0 comments	Download
M	expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Release/expected-results.json	View	9 chunks	+10 lines, -10 lines	0 comments	Download
M	expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json	View	5 chunks	+11 lines, -9 lines	0 comments	Download
M	expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json	View	6 chunks	+14 lines, -11 lines	0 comments	Download
M	expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json	View	6 chunks	+11 lines, -20 lines	0 comments	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json	View	6 chunks	+13 lines, -22 lines	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json	View	6 chunks	+13 lines, -22 lines	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json	View	6 chunks	+13 lines, -22 lines	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json	View	6 chunks	+13 lines, -22 lines	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json	View	3 chunks	+7 lines, -13 lines	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json	View	3 chunks	+7 lines, -13 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

bsalomon

6 years ago (2014-12-15 18:50:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e23f20e320a7b3ef27f2cd7b1a12d70ef80b31be (presubmit successful).

Expand Messages | Collapse Messages