Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 796303006: remove COMPILE_ASSERT macro from blink (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Nico
CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

remove COMPILE_ASSERT macro from blink All usage of the COMPILE_ASSERT macro in blink have now been converted to c++'s static_assert. BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/wtf/Assertions.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mostyn Bramley-Moore
@Nico: there are a couple of CLs to land before this, but perhaps you can ...
6 years ago (2014-12-19 12:42:02 UTC) #2
Nico
lgtm, nice :-)
6 years ago (2014-12-19 19:04:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796303006/1
6 years ago (2014-12-19 20:32:41 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-19 21:54:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187564

Powered by Google App Engine
This is Rietveld 408576698