Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 796263002: Remove synchronous GetDisplays() and Configure() from NativeDisplayDelegate (Closed)

Created:
6 years ago by dnicoara
Modified:
6 years ago
Reviewers:
Daniel Erat, spang
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@async-refactor5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove synchronous GetDisplays() and Configure() from NativeDisplayDelegate Cleaning up since the entry points should not be used/needed anymore. Also removing the Configure() calls from TakeControl() and replace them with a call to probe and configure displays. BUG=429746 Committed: https://crrev.com/eddd4aa229c29b89b50a60ba4ec243c8114d8fc5 Cr-Commit-Position: refs/heads/master@{#308250}

Patch Set 1 #

Patch Set 2 : Need to force configure in TakeControl() #

Patch Set 3 : Removed deprecated calls from TestNativeDisplayDelegate and update the ExternalControl test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -99 lines) Patch
M ui/display/chromeos/display_configurator.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M ui/display/chromeos/test/test_native_display_delegate.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ui/display/chromeos/test/test_native_display_delegate.cc View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 3 chunks +8 lines, -18 lines 0 comments Download
M ui/display/types/native_display_delegate.h View 2 chunks +4 lines, -11 lines 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.cc View 2 chunks +1 line, -12 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_dri.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_dri.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.cc View 2 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dnicoara
PTAL Depends on https://codereview.chromium.org/801493002/ derat@ for everything spang@ for Ozone
6 years ago (2014-12-12 01:42:45 UTC) #2
Daniel Erat
lgtm
6 years ago (2014-12-12 16:28:25 UTC) #3
spang
lgtm
6 years ago (2014-12-12 18:20:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796263002/20001
6 years ago (2014-12-12 22:36:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796263002/20001
6 years ago (2014-12-13 02:38:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/7584)
6 years ago (2014-12-13 03:13:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796263002/40001
6 years ago (2014-12-13 03:57:42 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-13 04:29:05 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-13 04:29:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eddd4aa229c29b89b50a60ba4ec243c8114d8fc5
Cr-Commit-Position: refs/heads/master@{#308250}

Powered by Google App Engine
This is Rietveld 408576698