ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc - Issue 796253002: Fix use-after-free when browser is closed during a drop-drop on desktop Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

Issue 796253002: Fix use-after-free when browser is closed during a drop-drop on desktop Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc ('k') | ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

index 5bad49a3bfda60fb4783aedf8e67fcec32dd3f88..29676c338bc07e08ea4e35456f4a50ad686da1fc 100644

--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

@@ -431,11 +431,12 @@ DesktopDragDropClientAuraX11::DesktopDragDropClientAuraX11(

}

DesktopDragDropClientAuraX11::~DesktopDragDropClientAuraX11() {

- g_live_client_map.Get().erase(xwindow_);

- // Make sure that all observers are unregistered from source and target

- // windows. This may be necessary when the parent native widget gets destroyed

- // while a drag operation is in progress.

+ // This is necessary when the parent native widget gets destroyed while a drag

+ // operation is in progress.

+ move_loop_->EndMoveLoop();

NotifyDragLeave();

+ g_live_client_map.Get().erase(xwindow_);

}

// static