Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: chrome/browser/net/predictor.cc

Issue 796213002: Instrumenting Predictor::StartSomeQueuedResolutions and ProfileIOData::Init to find jank (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/predictor.cc
diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc
index d38bb299bd061e63ec5c92584e306d2b9b765f03..a6a61c686ae7135292694cf70a7fc8a883efd06b 100644
--- a/chrome/browser/net/predictor.cc
+++ b/chrome/browser/net/predictor.cc
@@ -1166,6 +1166,11 @@ void Predictor::StartSomeQueuedResolutions() {
while (!work_queue_.IsEmpty() &&
pending_lookups_.size() < max_concurrent_dns_lookups_) {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
+ tracked_objects::ScopedTracker tracking_profile1(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436671 Predictor::StartSomeQueuedResolutions1"));
+
const GURL url(work_queue_.Pop());
UrlInfo* info = &results_[url];
DCHECK(info->HasUrl(url));
@@ -1177,7 +1182,19 @@ void Predictor::StartSomeQueuedResolutions() {
}
LookupRequest* request = new LookupRequest(this, host_resolver_, url);
+
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
+ tracked_objects::ScopedTracker tracking_profile2(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436671 Predictor::StartSomeQueuedResolutions2"));
+
int status = request->Start();
+
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
+ tracked_objects::ScopedTracker tracking_profile3(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "436671 Predictor::StartSomeQueuedResolutions3"));
+
if (status == net::ERR_IO_PENDING) {
// Will complete asynchronously.
pending_lookups_.insert(request);
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698