Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 796153002: Fix for a check failure in ftp listing (Closed)

Created:
6 years ago by jungshik at Google
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Visibility:
Public.

Description

Fix for a check failure in ftp listing The root cause is described in http://bugs.icu-project.org/trac/ticket/11421 The original two line fix is from gguangle@gmail.com. It was momdified to the minimum necessary because only |baseName| should be reset. TBR=phajdan.jr@chromium.org BUG=403902 TEST=Speculative: On Windows with the display language set to one other than English (e.g. ko, pt-BR, zh-CN, etc; just setting the default locale to one of them does not work on Win 7 or later or using --lang=foo does not work), start Chrome and go to ftp://ftp.vim.org. Render process should not crash. Committed: https://chromium.googlesource.com/chromium/deps/icu/+/6bbe98e616238851d2bc26a9ed26be521ed50ea4

Patch Set 1 #

Patch Set 2 : desc. change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M source/common/locid.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
jungshik at Google
6 years ago (2014-12-11 21:59:39 UTC) #1

Powered by Google App Engine
This is Rietveld 408576698