Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 796143003: Fix EOS buffer handling in spork. (Closed)

Created:
6 years ago by DaleCurtis
Modified:
6 years ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix EOS buffer handling in spork. BUG=none TEST=playback! Committed: https://crrev.com/433edd528474239c3094cf8b339296464b1dec52 Cr-Commit-Position: refs/heads/master@{#308037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
DaleCurtis
6 years ago (2014-12-12 00:38:42 UTC) #2
xhwang
Thanks! LGTM!
6 years ago (2014-12-12 01:27:01 UTC) #3
xhwang
BTW, you are the first one using Spork in a CL ;)
6 years ago (2014-12-12 01:27:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796143003/1
6 years ago (2014-12-12 02:02:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 02:51:49 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 02:52:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/433edd528474239c3094cf8b339296464b1dec52
Cr-Commit-Position: refs/heads/master@{#308037}

Powered by Google App Engine
This is Rietveld 408576698