Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 796123002: Fix TODO by removing use of getwd() in nacl-spawn (Closed)

Created:
6 years ago by Sam Clegg
Modified:
6 years ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix TODO by removing use of getwd() in nacl-spawn This also fixes the build which is currently broken for glibc due to warning about use of getwd() combined with recent addition of -Werror. BUG= https://code.google.com/p/naclports/issues/detail?id=109 TEST= run devenv locally Committed: https://chromium.googlesource.com/external/naclports/+/94aa2ba63679bca1404db21f45cd7febe05ea817

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M ports/nacl-spawn/nacl_spawn.cc View 1 chunk +4 lines, -8 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Sam Clegg
6 years ago (2014-12-11 21:02:58 UTC) #2
binji
https://codereview.chromium.org/796123002/diff/1/ports/nacl-spawn/nacl_spawn.cc File ports/nacl-spawn/nacl_spawn.cc (left): https://codereview.chromium.org/796123002/diff/1/ports/nacl-spawn/nacl_spawn.cc#oldcode58 ports/nacl-spawn/nacl_spawn.cc:58: // https://code.google.com/p/naclports/issues/detail?id=109 reference this bug?
6 years ago (2014-12-11 23:19:57 UTC) #3
Sam Clegg
6 years ago (2014-12-11 23:22:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94aa2ba63679bca1404db21f45cd7febe05ea817 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698