Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 796113003: Upstream constant related functions (Closed)

Created:
6 years ago by gone
Modified:
6 years ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream constant related functions * Moves some functions that deal TabState filenames to TabState from TabPersistentStore downstream. * Moves DOCUMENT_SCHEME from IntentHandler.java to UrlConstants.java with similar schemes. Note that the DOCUMENT_SCHEME doesn't include the "://" string like the other Java scheme constants; this is because the Document classes use a real Uri parse to parse the scheme instead of doing a plain old TextUtils.equals() comparison. BUG=415747 Committed: https://crrev.com/dad5c7e37ebf92ec62e4b940029d6a0236f44e5e Cr-Commit-Position: refs/heads/master@{#308011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/TabState.java View 4 chunks +39 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
aurimas (slooooooooow)
lgtm
6 years ago (2014-12-11 23:10:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796113003/1
6 years ago (2014-12-11 23:10:53 UTC) #6
gone
dtrainor@ for OWNERS.
6 years ago (2014-12-11 23:11:09 UTC) #8
David Trainor- moved to gerrit
lgtm
6 years ago (2014-12-11 23:12:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 00:38:33 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 00:39:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dad5c7e37ebf92ec62e4b940029d6a0236f44e5e
Cr-Commit-Position: refs/heads/master@{#308011}

Powered by Google App Engine
This is Rietveld 408576698