Issue 796103002: Pull PRESUBMIT test mocks out of //PRESUBMIT_test.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 796103002: Pull PRESUBMIT test mocks out of //PRESUBMIT_test.py. (Closed)

Created:
6 years ago by blundell

Modified:
6 years ago

Reviewers:
jamesr, eseidel

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Pull PRESUBMIT test mocks out of //PRESUBMIT_test.py. This CL pulls the mocks defined in //PRESUBMIT_test.py into a standalone file so that they can be reused. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8e4e30a18b8a472039bcb39ebbc6091e8ec1b48a

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -81 lines)			Patch
	M	PRESUBMIT_test.py	View		1 chunk	+2 lines, -81 lines	0 comments	Download
	A	PRESUBMIT_test_mocks.py	View		1 chunk	+109 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

blundell

6 years ago (2014-12-12 06:26:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8e4e30a18b8a472039bcb39ebbc6091e8ec1b48a (presubmit successful).