DescriptionRevert of Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (patchset #3 id:40001 of https://codereview.chromium.org/794583004/)
Reason for revert:
Broke again android perf bots and nexus 7 debug with error:
CRITICAL:root:Cannot set Chrome command line. Fix this by flashing to a userdebug build.
Original issue's description:
> Reland of Migrate DeviceUtils.ReadFile to adb_wrapper
>
> Original description:
>
> The implementation is based on a simple 'cat' run by shell on the
> device (with optional as_root).
>
> Interface changes:
> - The return value is a string (instead of a list of lines).
> - An exception is raised if the file cannot be read
> (instead of returning an empty list).
>
> Original CL: https://codereview.chromium.org/775333002/
>
> BUG=267773
>
> Committed: https://crrev.com/a8d3b82a9c779568ee64ec5c261c6c7024ef8759
> Cr-Commit-Position: refs/heads/master@{#307881}
TBR=jbudorick@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=267773
Committed: https://crrev.com/a485981c9e60877f4a7435c3726eb19149b52589
Cr-Commit-Position: refs/heads/master@{#307904}
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 9 (2 generated)
|