Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 796013004: Revert of Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (Closed)

Created:
6 years ago by perezju
Modified:
6 years ago
Reviewers:
jbudorick, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, telemetry+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (patchset #3 id:40001 of https://codereview.chromium.org/794583004/) Reason for revert: Broke again android perf bots and nexus 7 debug with error: CRITICAL:root:Cannot set Chrome command line. Fix this by flashing to a userdebug build. Original issue's description: > Reland of Migrate DeviceUtils.ReadFile to adb_wrapper > > Original description: > > The implementation is based on a simple 'cat' run by shell on the > device (with optional as_root). > > Interface changes: > - The return value is a string (instead of a list of lines). > - An exception is raised if the file cannot be read > (instead of returning an empty list). > > Original CL: https://codereview.chromium.org/775333002/ > > BUG=267773 > > Committed: https://crrev.com/a8d3b82a9c779568ee64ec5c261c6c7024ef8759 > Cr-Commit-Position: refs/heads/master@{#307881} TBR=jbudorick@chromium.org,skyostil@chromium.org NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/a485981c9e60877f4a7435c3726eb19149b52589 Cr-Commit-Position: refs/heads/master@{#307904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -75 lines) Patch
M build/android/pylib/device/device_utils.py View 3 chunks +17 lines, -20 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 2 chunks +42 lines, -19 lines 0 comments Download
M build/android/pylib/flag_changer.py View 3 chunks +5 lines, -8 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/pylib/perf/thermal_throttle.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/tombstones.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py View 2 chunks +5 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
perezju
Created Revert of Reland of Migrate DeviceUtils.ReadFile to adb_wrapper
6 years ago (2014-12-11 15:53:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796013004/1
6 years ago (2014-12-11 15:54:12 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-11 15:54:14 UTC) #4
jbudorick
lgtm
6 years ago (2014-12-11 16:04:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796013004/1
6 years ago (2014-12-11 16:05:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 16:06:15 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-11 16:07:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a485981c9e60877f4a7435c3726eb19149b52589
Cr-Commit-Position: refs/heads/master@{#307904}

Powered by Google App Engine
This is Rietveld 408576698